| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: PANIC: invalid index offnum: 186 when processing BRIN indexes in VACUUM |
| Date: | 2017-10-31 19:46:32 |
| Message-ID: | 13135.1509479192@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> maybe
> we just have some run-of-the-mill bugs to find, like the off-the-end
> bug I spotted in brin_doupdate. There's apparently at least one
> more, but given the error message it must be something like not
> checking for a page to have turned into a revmap page. Shouldn't
> be too hard to find...
Actually, I think it might be as simple as the attached.
brin_getinsertbuffer checks for the old page having turned into revmap,
but the "samepage" path in brin_doupdate does not :-(
With this applied, Alvaro's version of the test case has survived
without error for quite a bit longer than its former MTBF. There
might still be some issues though in other code paths.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-brin_doupdate.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-10-31 20:21:22 | Re: SQL procedures |
| Previous Message | Peter Eisentraut | 2017-10-31 19:38:05 | Transaction control in procedures |