| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dave Byrne <dbyrne(at)mdb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Possible Bug in pg_upgrade |
| Date: | 2011-08-11 07:02:29 |
| Message-ID: | 1313046149.5229.1.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On ons, 2011-08-10 at 18:53 -0400, Tom Lane wrote:
> Dave Byrne <dbyrne(at)mdb(dot)com> writes:
> > Attached is a patch that skips orphaned temporary relations in pg_upgrade if they are lingering around. It works for 9.0 -> 9.1 upgrades, however I wasn't able to tell when pg_class.relistemp was added so if it was unavailable in versions prior to 9.0 an additional check will have to be added.
>
> I'm inclined to think the correct fix is to revert the assumption that
> the old and new databases contain exactly the same number of tables ...
> that seems to have a lot of potential failure modes besides this one.
It's basically checking whether pg_dump -s worked. That doesn't seem
like a good use of time.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-08-11 07:06:36 | Re: sha1, sha2 functions into core? |
| Previous Message | Heikki Linnakangas | 2011-08-11 06:21:17 | Re: WIP: Fast GiST index build |