| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: lazy vxid locks, v3 |
| Date: | 2011-08-01 15:21:19 |
| Message-ID: | 1312212079.29391.111.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2011-08-01 at 08:12 -0400, Robert Haas wrote:
> > Is the "&& LocalTransactionIdIsValid(lxid)" a guard against calling
> > VirtualXactLockTableCleanup twice? Can that happen? Or is it just
> > defensive coding to avoid making an additional assumption?
>
> lxid there is just a local variable storing the value that we
> extracted from fpLocalTransactionId while holding the lock. I named
> it that way just as a mnemonic for the type of value that it was, not
> intending to imply that it was copied from MyProc->lxid.
I know, this is the other purpose of fpLocalTransactionId that I was
talking about. Is it just a guard against calling
VirtualXactLockTableCleanup twice?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-08-01 15:25:01 | Re: Hot standby and GiST page splits (was Re: WIP: Fast GiST index build) |
| Previous Message | Robert Haas | 2011-08-01 15:18:36 | Re: Access to current database from C-language function |