Re: pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
Date: 2011-07-25 19:59:14
Message-ID: 1311623954.22497.17.camel@laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, 2011-07-25 at 20:39 +0100, Dave Page wrote:
> On Mon, Jul 25, 2011 at 8:33 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> >> Something like the attached? (lightly tested!)
> >>
> >
> > Oh yeah, thanks, it works right out of the box for me.
>
> Sweet :-)
>
> > So I guess we have it all? or is there anything missing?
>
> You need to change _static to images I think.

Done, and pushed.

> Plus, the top-level
> Makefile.am needs to be updated to include the new/renamed files.
>

You mean something like this?

diff --git a/Makefile.am b/Makefile.am
index 677ec5c..d1d19f3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -34,7 +34,8 @@ EXTRA_DIST = \

TMP_docs = \
$(top_srcdir)/docs/en_US/*.css \
- $(top_srcdir)/docs/en_US/*.html \
+ $(top_srcdir)/docs/en_US/*.rst \
+ $(top_srcdir)/docs/en_US/conf.py \
$(top_srcdir)/docs/en_US/pgadmin3.hh* \
$(top_srcdir)/docs/en_US/hints/*.html \
$(top_srcdir)/docs/en_US/images/*.png \

> > And if we have it all, should I commit it ASAP?
>
> Sure - it seems to be good now :-).
>
> Don't forget to update the build instructions.
>

In the INSTALL file, right? or is there another file I should care
about?

> > how are we going to
> > organize the work on the documentation?
>
> I think we need to draw up a standard, and then just start working on
> it as and when we can.
>
>

OK.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-07-25 20:01:50 Re: pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
Previous Message Guillaume Lelarge 2011-07-25 19:43:42 Re: Handling connection loss