Re: pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

On Fri, 2011-07-15 at 11:41 +0530, Ashesh Vashi wrote:
>
> On Fri, Jul 15, 2011 at 11:28 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>
> On Fri, 2011-07-15 at 10:59 +0530, Ashesh Vashi wrote:
> > Hi Guilliaume,
> >
> > On Fri, Jul 15, 2011 at 2:22 AM, Guillaume Lelarge
> > <guillaume(at)lelarge(dot)info> wrote:
> >
> > On Thu, 2011-07-14 at 19:34 +0200, Guillaume Lelarge
> wrote:
> > > On Thu, 2011-07-14 at 14:46 +0200, Guillaume
> Lelarge wrote:
> > > > On Sun, 2011-07-03 at 09:15 +0100, Dave Page
> wrote:
> > > > > On Sat, Jul 2, 2011 at 2:09 PM, Guillaume
> Lelarge
> > > > > <guillaume(at)lelarge(dot)info> wrote:
> > > > > > On Thu, 2011-06-30 at 09:32 +0100, Dave Page
> wrote:
> > > > > >> On Thu, Jun 30, 2011 at 9:08 AM, Guillaume
> Lelarge
> > > > > >> <guillaume(at)lelarge(dot)info> wrote:
> > > > > >> >
> > > > > >> > Could be the next thing I do. Last time
> we talked
> > about it, I had done
> > > > > >> > some work on sphynx. IIRC, I had two main
> things to
> > do:
> > > > > >> >
> > > > > >> > * try to build on Windows, and Mac
> > > > > >> > * change the build chain so that it
> buils
> > automatically the manual
> > > > > >> >
> > > > > >> > Did I forgot something?
> > > > > >>
> > > > > >> No, I think that's it.
> > > > > >>
> > > > > >
> > > > > > OK, I've done some work on this.
> > > > > >
> > > > > > Linux prep steps
> > > > > >
> > > > > > * install Python (with your distro package
> manager)
> > > > > > * install the python easy_install module
> > > > > > * install Sphinx (should be as easy as
> "easy_install
> > -U Sphinx)
> > > > > >
> > > > > > Windows prop steps
> > > > > >
> > > > > > * download
> >
> http://www.python.org/ftp/python/2.7.2/python-2.7.2.msi
> > > > > > * install python-2.7.2.msi
> > > > > > * download
> > > > > >
> >
> http://pypi.python.org/packages/2.7/s/setuptools/setuptools-0.6c11.win32-py2.7.exe#md5=57e1e64f6b7c7f1d2eddfc9746bbaf20
> > > > > > * install setuptools-0.6c11.win32-py2.7.exe
> > > > > > * include C:\Python27\Scripts in %path%
> > > > > > * in cmd, type "easy_install.exe -U Sphinx"
> > > > > >
> > > > > > Mac OS X prep steps
> > > > > >
> > > > > > I already had Python and the easy_install
> module, so I
> > just had to
> > > > > > install Sphinx with the usual command
> ("easy_install
> > -U Sphinx")
> > > > > >
> > > > > > Windows Visual Studio project changes
> > > > > >
> > > > > > It should be quite simple. We simply need to
> change
> > the Docs project so
> > > > > > that it launches the "make html" command
> instead of
> > the "builddocs.bat".
> > > > > > We'll also have to add all the rst files in
> this
> > project.
> > > > > >
> > > > > > Linux, and Mac OS X Makefile
> > > > > >
> > > > > > This should also be quite simple. We only
> need to
> > change the Makefile so
> > > > > > that it calls the Make in the docs
> directory.
> > > > > >
> > > > > > If it seems good enough for you, I'll update
> the rst
> > filess with the new
> > > > > > changes. I'll update the build system. And
> creates one
> > big patch for all
> > > > > > of this. OK?
> > > > >
> > > > > OK.
> > > > >
> > > >
> > > > Update on the files done. You can find that
> preliminary
> > work on
> > > > https://github.com/gleu/pgadmin3/tree/docs
> (branch name is
> > docs).
> > > >
> > > > I still need to work on the build system.
> > > >
> > >
> > > OK. Instead of working on the build system, I
> worked a bit
> > on the
> > > template system. We should be able to do what we
> want. I'm
> > not sure we
> > > really need to do this now, as ideas and needs
> will come
> > during the
> > > writing of the manual.
> > >
> > > But I still have to work on the build system. I'll
> try to
> > change the
> > > Windows build system this evening.
> > >
> >
> >
> > OK, so here is the patch I have now. And I have a
> big issue
> > with it.
> > Once "make.bat htmlhelp" is done, builddocs.bat
> stops. No
> > error, no
> > nothing. Everything seems fine, even if it didn't
> execute the
> > rest of
> > the batch file. It happens when I launch it from
> Visual Studio
> > and when
> > I launch it from the console. Same behaviour. I have
> > absolutely no idea
> > why this is happening. Any idea on the error I made?
> > By any chance, Did you forgot to add doc/en_US/make.bat file
> in the
> > patch?
> > I can't see that file anywhere in the pgadmin3 directory.
> >
>
>
> It's already in the docs branch of my git repository:
>
> https://github.com/gleu/pgadmin3/blob/docs/docs/en_US/make.bat
>
> It hasn't changed since.
> Sorry - I was checking master, did not follow the complete mail.
> What happens, if you change the following line?
> %SPHINXBUILD% -b html %ALLSPHINXOPTS% %BUILDDIR%/html
> to
> CALL %SPHINXBUILD% -b html %ALLSPHINXOPTS% %BUILDDIR%/html
>

It didn't work. But I tried a "CALL make.bat htmlhelp, and it worked
great. I'll push the windows build on my branch. Thanks, Ashesh!

Now on the unix build.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com