|From:||Jeff Davis <pgsql(at)j-davis(dot)com>|
|To:||Robert Haas <robertmhaas(at)gmail(dot)com>|
|Subject:||Re: lazy vxid locks, v2|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, 2011-07-05 at 13:15 -0400, Robert Haas wrote:
> On Tue, Jul 5, 2011 at 1:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > Here is an updated version of the "lazy vxid locks" patch , which
> > applies over the latest "reduce the overhead of frequent table
> > locks" patch.
> >  https://commitfest.postgresql.org/action/patch_view?id=585
> >  https://commitfest.postgresql.org/action/patch_view?id=572
> And then I forgot the attachment.
The patch looks good, and I like the concept.
My only real comment is one that you already made: the
BackendIdGetProc() mechanism is not "awesome". However, that seems like
material for a separate patch, if at all.
Big disclaimer: I did not do any performance review, despite the fact
that this is a performance patch.
I see that there are some active performance concerns around this patch,
specifically that it may cause an increase in spinlock contention:
Fortunately, there's a subsequent discussion that shows a lot of
I'll mark this "waiting on author" pending the results of that
I like the approach you're taking with this series of patches, so
perhaps we shouldn't set the bar so high that you have to remove all of
the bottlenecks before making any progress. Then again, maybe there's
not a huge cost to leaving these patches on the shelf until we're sure
that they lead somewhere.
|Next Message||Tatsuo Ishii||2011-07-14 06:48:24||Re: Re: patch review : Add ability to constrain backend temporary file space|
|Previous Message||Jeff Davis||2011-07-14 02:08:19||Re: [RRR] Three patches which desperately need reviewers|