spurious use of %m format in pg_upgrade

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: spurious use of %m format in pg_upgrade
Date: 2011-07-07 04:03:12
Message-ID: 1310011393.17968.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pg_upgrade's pg_scandir_internal() makes use of the non-standard %m
format:

pg_log(PG_FATAL, "could not open directory \"%s\": %m\n", dirname);

Is this an oversight, or is there an undocumented assumption that this
code will only be used on platforms where %m works?

(Which platforms don't have scandir() anyway?)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-07-07 04:22:09 Re: spurious use of %m format in pg_upgrade
Previous Message Josh Berkus 2011-07-07 04:02:07 9.2 CF2: 20 days in