Re: Asymmetric partition-wise JOIN

From: David Steele <david(at)pgmasters(dot)net>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Kohei KaiGai <kaigai(at)heterodb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Asymmetric partition-wise JOIN
Date: 2020-03-27 14:44:03
Message-ID: 1309907d-f5f7-7d10-e3fd-321f75ba46a5@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Thomas,

On 12/27/19 2:34 AM, Kohei KaiGai wrote:
>
> This crash was reproduced on our environment also.
> It looks to me adjust_child_relids_multilevel() didn't expect a case
> when supplied 'relids'
> (partially) indicate normal and non-partitioned relation.
> It tries to build a new 'parent_relids' that is a set of
> appinfo->parent_relid related to the
> supplied 'child_relids'. However, bits in child_relids that indicate
> normal relations are
> unintentionally dropped here. Then, adjust_child_relids_multilevel()
> goes to an infinite
> recursion until stack limitation.
>
> The attached v2 fixed the problem, and regression test finished correctly.

Any thoughts on the new version of this patch?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2020-03-27 14:58:46 Re: Allow cluster owner to bypass authentication
Previous Message Julien Rouhaud 2020-03-27 14:42:50 Re: Planning counters in pg_stat_statements (using pgss_store)