Re: Fwd: Discussion - Search Objects

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Fwd: Discussion - Search Objects
Date: 2011-07-04 21:23:47
Message-ID: 1309814627.2202.4.camel@laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > Could somebody review the patch and maybe commit it?
> >
>
> I'll look into it tonight, unless someone beats me to it.
>

Seems mostly good to me, but I have too questions:

* why do you use twice the Trim command in
"browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?

* why is the search object menu only available to non maintenance DB?
(((pgDatabase *)obj)->GetName() != ((pgDatabase
*)obj)->GetServer()->GetDatabaseName())

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Jasmin Dizdarevic 2011-07-04 21:42:12 Re: Fwd: Discussion - Search Objects
Previous Message Guillaume Lelarge 2011-07-04 19:53:03 Re: [BUG] Index operator class + collation = bad SQL