| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Schreiber <daniel(dot)schreiber(at)hrz(dot)tu-chemnitz(dot)de> |
| Subject: | Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times |
| Date: | 2026-04-22 19:23:53 |
| Message-ID: | 1309665.1776885833@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> If anyone has thoughts on that, I'd love to hear them. I don't mind
> removing this unnecessary code in HEAD, or even backpatching as a
> courtesy -- but if it were up to me, I would not guarantee zero global
> resource leaks across libpq and its entire dependency graph.
I agree that we have no real ability to guarantee that.
Still, as far as the presented patch goes, it seems like a clear
win so I'd vote for fix-and-backpatch.
Should we write the arguments as BIO_TYPE_NONE | BIO_TYPE_SOURCE_SINK
rather than just BIO_TYPE_SOURCE_SINK?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-04-22 22:10:07 | Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times |
| Previous Message | Nico Williams | 2026-04-22 19:22:09 | Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-04-22 19:31:18 | Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Previous Message | Nico Williams | 2026-04-22 19:22:09 | Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times |