| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | 花田 茂 <hanada(at)metrosystems(dot)co(dot)jp> |
| Cc: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in SQL/MED? |
| Date: | 2011-06-30 14:40:33 |
| Message-ID: | 1309444757-sup-2714@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from 花田 茂's message of jue jun 30 06:00:23 -0400 2011:
> I attached a patch which fixes file_fdw to check required option
> (filename) in its validator function. I think that such requirement
> should be checked again in PlanForeignScan(), as it had been so far.
> Note that this patch requires fdw.patch has been applied.
I think it'd be good to keep the error check in fileGetOptions() just to
ensure that we don't crash in case a catalog is messed up with, though
I'd degrade it to elog(ERROR) from ereport.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2011-06-30 15:04:56 | Re: Small patch for GiST: move childoffnum to child |
| Previous Message | Steve Singer | 2011-06-30 13:25:14 | Re: libpq SSL with non-blocking sockets |