| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove one use of IDENT_USERNAME_MAX |
| Date: | 2019-10-29 14:34:00 |
| Message-ID: | 13092.1572359640@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-10-28 14:45, Tom Lane wrote:
>> Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
>>> In think one of the reasons for the coding is the fact that *pw is
>>> described to be placed in the static area, which can be overwritten by
>>> succeeding calls to getpw*() functions.
>> Good point ... so maybe pstrdup instead of using a fixed-size buffer?
> Maybe. Or we just decide that check_usermap() is not allowed to call
> getpw*(). It's just a string-matching routine, so it doesn't have any
> such business anyway.
I'm okay with that as long as you add a comment describing this
assumption.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-10-29 15:48:24 | Re: Add const qualifiers to internal range type APIs |
| Previous Message | Shay Rojansky | 2019-10-29 14:27:11 | Re: strpos behavior change around empty substring in PG12 |