Re: Discussion - Search Objects

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Discussion - Search Objects
Date: 2011-06-16 20:39:02
Message-ID: 1308256742.2036.19.camel@laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, 2011-06-16 at 22:31 +0200, Jasmin Dizdarevic wrote:
>
>
> 2011/6/16 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> On Wed, 2011-06-15 at 23:48 +0200, Jasmin Dizdarevic wrote:
> > Yeah, I know. All of the dialogs have a "binding" to some
> pgObject,
> > because all of them modifies something.
>
>
> No, see dlgFindAndReplace.
>
> > When I started working I had no clear picture about the
> class
> > hierarchy and I thought this would be an easier entry point.
> I can
> > change the prefix if this is wished.
> >
>
>
> Yeah, I think it would be better.
>
>
> I'm going to change that.
>
>
> > btw: You could help me with the factory class. Am I starting
> the
> > dialog correctly?
> >
>
>
> Seems good to me. My only question is: why in
> frmMain.ccp and not in
> frmSearchObject.cpp? I first tried the latter, and was
> surprised to find
> it in the former.
>
> I'm currently surprised myself ;)
>
>
>
> BTW, can you stop top-posting please? Thanks.
> Regards.
>
> I'll try it.
>
>
> One more thing:
>
>
> Can somebody say me how to merge different patches to a single one?
> I've made 3-4 commits and would like to have exactly one patch file.
> It's not so important, but it would be very nice.
>

I suppose you're talking about "git rebase". Do a "git rebase -i" to get
the interactive mode. Let the first commit the way it is. Use squash for
the other commits.

> Generally, I wanna thank you for your patience and help - I know this
> can be frustrating to answer questions, that are clear to you since a
> long time :)
>

No problem :)

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-06-16 20:41:40 Re: First test of the Database Designer
Previous Message Jasmin Dizdarevic 2011-06-16 20:31:09 Re: Discussion - Search Objects