From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Object translation mechanism is, umm, broken. |
Date: | 2011-06-03 12:45:03 |
Message-ID: | 1307105104.2026.3.camel@laptop |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
On Thu, 2011-06-02 at 08:54 +0000, Dave Page wrote:
> [...]
> This commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4b8ae9d82c3b879eb02dda60908ed9590a674ec4
> (particularly the code in pgObject.cpp) is causing problems. I keep
> running into objects for which we now get messages like "Refreshing
> unknown object of type Replication", which I believe used to work just
> fine. I've just hit it with the Slony replication cluster object, and
> now have a sneaking suspicion it's also going to affect all the other
> slony object types.
>
Right.
> Aside from the fact that the code is incomplete, it's a serious
> modularity violation. We shouldn't have a giant conditional statement
> in a parent class that has knowledge of each of the different classes
> that might be derived from that object. Instead, each of the child
> classes should override a common function.
>
> Can you look at this please?
>
Working on it right now.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2011-06-03 13:24:26 | Re: Object translation mechanism is, umm, broken. |
Previous Message | Dave Page | 2011-06-03 11:41:32 | pgAdmin III commit: make style |