| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Brar Piening <lists(at)piening(dot)info>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Some 9.5beta2 backend processes not terminating properly? |
| Date: | 2016-01-04 15:49:37 |
| Message-ID: | 13067.1451922577@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-01-04 10:35:12 -0500, Robert Haas wrote:
>> If we don't know of a specific problem that would be fixed by
>> back-patching this commit to pre-9.5 branches, and it seems like we
>> don't, then I don't really see much upside to back-patching it. I
>> mean, yeah, we think that this is wrong because we think we know that
>> the behavior of Windows is different than what we thought when the
>> code was written. But if we were wrong then, we could be wrong now,
>> too. If so, it would be better to only have broken 9.5.
> I think it always was just a typo, given code a few lines down in the
> same function, added by the same commit, treated that case differently.
And, indeed, it was only because that code further down handled the case
correctly that nobody noticed for so long.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-01-04 15:51:20 | Re: custom function for converting human readable sizes to bytes |
| Previous Message | Robert Haas | 2016-01-04 15:48:38 | Re: comment typo in RewindTest.pm |