Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tim Uckun <timuckun(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date: 2011-05-25 16:41:18
Message-ID: 1306341572-sup-4765@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Excerpts from Bruce Momjian's message of mar may 24 15:59:59 -0400 2011:

> > I think you misread what I wrote, or I misexplained it, but never
> > mind. Matching locale names case-insensitively sounds reasonable to
> > me, unless someone has reason to believe it will blow up.
>
> OK, that's what I needed to hear. I have applied the attached patch,
> but only to 9.1 because of the risk of breakage. (This was only the
> first bug report of this, and we aren't 100% certain about the case
> issue.)

Hmm, I know the locale can be spelled "en_US.UTF-8" (note dash) in some
systems. So if you have a locale alias that makes en_US.utf8 the same
as en_US.UTF-8, the patched code would still not work. I wonder if
there's a need for canonicalization somewhere. Or maybe this is just
not worth the trouble.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2011-05-25 17:22:36 Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Previous Message Merlin Moncure 2011-05-25 14:06:29 Re: PostgreSQL 9.1beta 1 Some domains not being able to be auto cast to their base type

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-05-25 16:41:39 Re: [ADMIN] pg_class reltuples/relpages not updated by autovacuum/vacuum
Previous Message Kevin Grittner 2011-05-25 16:37:24 Re: [ADMIN] pg_class reltuples/relpages not updated by autovacuum/vacuum