Re: Status of DISTINCT-by-hashing work

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Status of DISTINCT-by-hashing work
Date: 2008-08-06 14:27:11
Message-ID: 13053.1218032831@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> writes:
> In my patch nodeWindow.c, some functions reach for its parent state
> node to get info of sort keys by using fcinfo->context. This works but
> is completely ugly.

Isn't that the same thing nodeAgg does: pass its AggState to aggregate
functions? I don't see anything ugly about it --- at least, any
alternative you care to name is likely to be far worse.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2008-08-06 14:29:38 Re: plan invalidation vs stored procedures
Previous Message Pavel Stehule 2008-08-06 13:41:51 Re: plan invalidation vs stored procedures