Skip site navigation (1) Skip section navigation (2)

Re: Couple of minor fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Couple of minor fixes
Date: 2006-04-09 19:24:41
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Attached match makes a couple of minor changes to get rid of some
> annoying compiler warnings:

> 1) backend/port/win32/sema.c declares a variable inline with the code.
> IIRC, that's only allowed in C++. Patch moves declaration to the top of
> the function.


> 2) timezone/localtime.c, transtime() has a const arcument in the
> implementation but non-const in declaration.

I did this the other way (make implementation match declaration).
I think the coding was in fact correct per spec, because const-ness
of an argument value is not part of the function signature.

> I'm also seeing a lot of signed/unsigned mismatch, but IIRC it was said
> at some point that we don't care about those.

In HEAD?  They're all cleaned up according to the compilers I use.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2006-04-09 19:27:21
Subject: Re: Couple of minor fixes
Previous:From: Alvaro HerreraDate: 2006-04-09 19:18:04
Subject: Re: Support Parallel Query Execution in Executor

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group