| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 |
| Date: | 2011-04-27 20:31:22 |
| Message-ID: | 1303936176-sup-8131@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Excerpts from Tom Lane's message of mié abr 27 17:10:37 -0300 2011:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
> >> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.
>
> > Apparently this change is causing Moa's SunStudio compiler to fail an
> > assertion.
>
> [ scratches head... ] Hard to see why, there's nothing at all
> interesting in that code.
I agree, but it fails exactly in that code, and started to fail
immediately after that patch.
Maybe casting the 2 to int64 would fix it?
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-27 20:52:10 | pgsql: Make a quick copy-editing pass over the 9.1 release notes. |
| Previous Message | Tom Lane | 2011-04-27 20:10:37 | Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yves Weißig | 2011-04-27 20:35:16 | Re: Best way to construct Datum out of a string? |
| Previous Message | Kevin Grittner | 2011-04-27 20:29:19 | Re: make world fails |