| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 |
| Date: | 2011-04-27 19:08:29 |
| Message-ID: | 1303931274-sup-6567@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.
>
> The expression that tried to round the value to the nearest TB could
> overflow, leading to bogus output as reported in bug #5993 from Nicola
> Cossu. This isn't likely to ever happen in the intended usage of the
> function (if it could, we'd be needing to use a wider datatype instead);
> but it's not hard to give the expected output, so let's do so.
Apparently this change is causing Moa's SunStudio compiler to fail an
assertion.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-04-27 19:11:31 | pgsql: Fix binary upgrade of altered typed tables |
| Previous Message | Andrew Dunstan | 2011-04-27 18:57:32 | pgsql: Revert "Force use of "%I64d" format for 64 bit ints on MinGW." |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-04-27 19:12:52 | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
| Previous Message | Andrew Dunstan | 2011-04-27 19:05:30 | Re: XML with invalid chars |