Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-12-14 20:09:48
Message-ID: 13033.1323893388@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> + # Disable FP optimizations that cause isinf errors on gcc 4.5+
> + PGAC_PROG_CC_CFLAGS_OPT([-fexcess-precision=standard])

Looks sane to me, except "isinf errors" is an awfully narrow reading of
the problem. Maybe just say "assorted errors"? Also, do we know that
gcc 4.5 poses the issue? I'm only aware of reports for 4.6 and 4.7.

> I guess we should backpatch it?

+1. Back branches will see these same problems as soon as anybody
tries to compile them with latest-n-greatest gcc.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-12-14 20:15:15 Re: SP-GiST versus index-only scans
Previous Message Jesper Krogh 2011-12-14 19:50:01 Re: SP-GiST versus index-only scans