Re: pg_upgrade and PGCLIENTENCODING

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade and PGCLIENTENCODING
Date: 2011-03-30 21:30:09
Message-ID: 1301520609.31317.10.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On ons, 2011-03-30 at 15:42 -0400, Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > pg_upgrade complains if any of the libpq connection variables are set.
> > That's probably reasonable by default, but it seems to me that we ought
> > to allow keeping PGCLIENTENCODING set, otherwise various values and
> > error messages that are coming from the servers will not be in the
> > encoding appropriate for the terminal.
>
> What is the error message? I don't see pg_upgrade checking
> PGCLIENTENCODING. I do check the cluster encodings.

It's done via check_for_libpq_envvars().

Actually, this is particular issue is new in 9.1, because the client
encoding wasn't a connection option before.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-03-30 21:35:50 Re: Problem with pg_upgrade?
Previous Message Bruce Momjian 2011-03-30 21:27:05 Re: Problem with pg_upgrade?