From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Subject: | Re: generic reloptions improvement |
Date: | 2009-01-04 23:37:08 |
Message-ID: | 1301.1231112228@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This is the patch in its final form. I have included a few macros to
> simplify the writing of amoptions routines.
Minor gripes:
* Does initialize_reloptions() need to be exported? It seems to be
only called within parseRelOptions(). It's far from clear who else
should be expected to call it.
* The HANDLE_ macros are dangerous as-is (dangling if/else). Need to
use the usual do/while trick.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Hitoshi Harada | 2009-01-05 00:16:23 | Re: WIP patch for basic window frame support |
Previous Message | Alex Hunsaker | 2009-01-04 23:32:44 | [PATCH] ALTER TABLE SET (compress_max_size... = ) |