From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to mark items as static or not used |
Date: | 2006-07-15 04:05:39 |
Message-ID: | 13005.1152936339@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> This time around, please do not remove API functions just because you
>> can't find a reference to them in the core code. I would like to see
>> a posted, discussed patch first.
> OK, here is my match to mark items as static or not used:
> ftp://momjian.us/pub/postgresql/mypatches/static
By and large, this just demonstrates the silliness of using an automated
tool for this purpose :-(. The hits in gist and gin might be valid ---
Teodor would need to comment on that --- but almost every one of the
others is a "no, don't do that". As an example, you've successfully
reverted this recent patch in toto:
2006-04-26 20:46 tgl
* src/: backend/utils/adt/selfuncs.c, include/utils/selfuncs.h: If
we're going to expose VariableStatData for contrib modules to use,
then we should export a reasonable set of the supporting routines
too.
The fundamental problem with find_static is that it hasn't got a clue
about likely future changes, nor about what we think external add-ons
might want ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-15 04:11:18 | Re: Patch to mark items as static or not used |
Previous Message | Tom Lane | 2006-07-15 03:35:22 | pgsql: Fix some missing inclusions identified with new pgcheckdefines |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-07-15 04:11:18 | Re: Patch to mark items as static or not used |
Previous Message | Bruce Momjian | 2006-07-15 03:32:58 | Patch to mark items as static or not used |