Re: Suspicious strcmp() in src/backend/parser/parse_expr.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date: 2019-04-11 04:55:49
Message-ID: 12975.1554958549@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Apr 10, 2019 at 06:43:32PM -0400, Tom Lane wrote:
>> Indeed. Considering how much I hate using strcmp's result as a boolean,
>> you'd think I'd have got that right. Thanks for noticing!

> Would it be worth changing these as well?

I'd be +1 for that, just on the grounds of having consistent coding
style. But I'm not sufficiently excited about it to do the work
myself ...

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Pavel Stehule 2019-04-11 05:00:46 Re: BUG #15709: if drop exists syntax
Previous Message Jueve L 2019-04-11 04:51:46 Re: BUG #15709: if drop exists syntax