Re: Range Types (catversion.h)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Range Types (catversion.h)
Date: 2011-02-10 17:28:46
Message-ID: 1297358926.27157.496.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2011-02-10 at 12:04 -0500, Tom Lane wrote:
> "Erik Rijkers" <er(at)xs4all(dot)nl> writes:
> > On Wed, February 9, 2011 09:35, Jeff Davis wrote:
> >> Updated patch.
>
> > I just wanted to mention that this latest patch doesn't quite apply as-is, because of catversion changes.
>
> Just a note: standard practice is for submitted patches to *not* touch
> catversion.h. The committer will add that change before committing.
> Otherwise, it's just guaranteed to cause merge problems such as this
> one. (It's not unreasonable to mention the need for a catversion bump
> in the description of the patch, if you think the committer might not
> realize it.)

OK, I'll remove that then.

I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing, but I agree that it seems easier this way.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shaun Thomas 2011-02-10 17:30:46 Re: Why we don't want hints Was: Slow count(*) again...
Previous Message Kevin Grittner 2011-02-10 17:27:18 Re: Why we don't want hints Was: Slow count(*) again...