| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Per-column collation, the finale |
| Date: | 2011-02-03 15:53:28 |
| Message-ID: | 1296748408.6442.1.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote:
> > This is good stuff. I'll send you a new patch in a day or three for
> > perhaps another round of performance tests. Some of the other
> issues
> > above can perhaps be postponed for follow-up patches.
>
> I agree -- if the performance-when-unused gets solid, none of my other
> comments ought to hold things up.
Here is a new patch.
The main change is in varstr_cmp(), avoiding the calls to
pg_newlocale_from_collation() when the default locale is used. This
accounts for the performance regression in my tests. It also addresses
some of your refactoring ideas.
| Attachment | Content-Type | Size |
|---|---|---|
| collate-20110203.patch.gz | application/x-gzip | 96.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tim Bunce | 2011-02-03 16:09:51 | Re: Optimize PL/Perl function argument passing [PATCH] |
| Previous Message | Bruce Momjian | 2011-02-03 15:47:33 | is_absolute_path cleanup |