Re: .gitignore patch for coverage builds

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: .gitignore patch for coverage builds
Date: 2011-01-26 22:41:39
Message-ID: 1296081501-sup-1890@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Tom Lane's message of mié ene 26 19:20:52 -0300 2011:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Wed, Jan 26, 2011 at 4:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Ick. That's an awful lot of stuff to have global ignores for.
>
> > The "coverage" directory ignore seems a little icky, but the rest
> > seems unlikely to pick up anything incidental.
>
> Tying /coverage to the root as in his V2 makes that better,

Hmm, I don't think that works, because you can run "make coverage" in
any subdir and it will create a "coverage" subdir there.

> but I'm
> still unexcited about the thesis that we should auto-ignore the results
> of any random tool somebody wants to run in their source tree.

Well, in this case it's not any random tool, because it's integrated
into our makefiles.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-26 22:41:44 Re: ALTER TYPE 3: add facility to identify further no-work cases
Previous Message Robert Haas 2011-01-26 22:40:28 Re: new compiler warnings