| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Steve Singer <ssinger_pg(at)sympatico(dot)ca> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: log_hostname and pg_stat_activity |
| Date: | 2011-01-19 01:07:28 |
| Message-ID: | 1295399209-sup-6400@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Steve Singer's message of mar ene 18 21:24:25 -0300 2011:
> Coding Review
> -------------
>
> As Alvaro pointed out BackendStatusShmemSize should be updated.
>
> To answer his question about why clientaddr works: clientaddr is a
> SockAddr which is a structure not a pointer so the data gets copied by
> value to beentry. That won't work for strings, I have no issues with
> how your allocating space in beentry and then strlcpy'ing the values.
Doh, of course. Thanks.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hitoshi Harada | 2011-01-19 01:16:26 | Re: REVIEW: PL/Python validator function |
| Previous Message | Hitoshi Harada | 2011-01-19 01:06:15 | Re: pl/python refactoring |