Re: REVIEW: Extensions support for pg_dump

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: REVIEW: Extensions support for pg_dump
Date: 2011-01-18 12:29:45
Message-ID: 1295353728-sup-5169@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Dimitri Fontaine's message of mar ene 18 07:01:55 -0300 2011:
> Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi> writes:

> >> It used to work this way with \i, obviously. Should the extension patch
> >> care about that and how? Do we want to RESET search_path or to manually
> >> manage it like we do for the client_min_messages and log_min_messages?
> > It was unintuitive to me to have search_path changed by SQL command as a
> > side effect. When using \i, not so much.

If the CREATE EXTENSION stuff all works in a transaction, perhaps it
would be easier if you used SET LOCAL. At the end of the transaction it
would reset to the original value automatically.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-01-18 12:32:07 Re: pg_basebackup for streaming base backups
Previous Message Anssi Kääriäinen 2011-01-18 12:29:42 Re: REVIEW: Extensions support for pg_dump