Re: Something fishy about the current Makefiles

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Something fishy about the current Makefiles
Date: 2011-01-07 00:54:15
Message-ID: 1294361655.19612.16392.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2011-01-06 at 13:53 -0500, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Thu, Jan 6, 2011 at 11:57 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Whilst fooling around with GIN, I have repeatedly observed that doing
> >> "make" in src/backend/access/gin, followed by "make install-bin" in
> >> src/backend, fails to rebuild the postgres executable --- it just
> >> installs the existing one. A second execution of "make install-bin"
> >> does notice that postgres is out of date and rebuilds it. This
> >> procedure for rebuilding after changing one or two .c files has always
> >> worked for me before. I can't avoid the suspicion that the recent
> >> changes to make things more parallel-friendly broke something.
>
> > I've noticed something like this as well, but haven't been able to
> > figure out exactly what is going wrong.
>
> I'm not entirely sure either, but it looks like the first upper "make"
> updates the objfiles.txt file in src/backend/access and then the second
> one realizes it has to rebuild postgres. Something about multi-level
> dependencies isn't quite right.

I had a weirdness with the dependency files a few days ago. The error
was a missing delimiter : at the end of one of the files. Stopped
everything cold until I added that character, then re-configured and not
a hint of the earlier problem.

Sounds like dependency is a common issue.

--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2011-01-07 01:15:15 Re: Streaming base backups
Previous Message Cédric Villemain 2011-01-07 00:47:39 Re: Streaming base backups