Tab completion for ALTER ... SET SCHEMA

From: andreas <andreas(at)proxel(dot)se>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Tab completion for ALTER ... SET SCHEMA
Date: 2010-12-18 01:34:54
Message-ID: 1292636094.3586.14.camel@jansson
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It has annoys me every time I want to move a table to another schema
that it completes to SET SCHEMA TO DEFAULT after a couple of presses of
the tab key. So today I decided to get off my lazy ass to write a tiny
patch to fix this behaviour. :)

My first patch for PostgreSQL so a question: Should I add this to the
open commitfest?

----

*** a/src/bin/psql/tab-complete.c
--- b/src/bin/psql/tab-complete.c
*************** psql_completion(char *text, int start, i
*** 1387,1392 ****
--- 1387,1399 ----
pg_strcasecmp(prev_wd, "USER") == 0)
COMPLETE_WITH_QUERY(Query_for_list_of_roles);

+ /* ALTER <object> <name> SET SCHEMA */
+ else if (pg_strcasecmp(prev4_wd, "ALTER") == 0 &&
+ pg_strcasecmp(prev2_wd, "SET") == 0 &&
+ pg_strcasecmp(prev_wd, "SCHEMA") == 0)
+ COMPLETE_WITH_QUERY(Query_for_list_of_schemas);
+
+
/* BEGIN, END, ABORT */
else if (pg_strcasecmp(prev_wd, "BEGIN") == 0 ||
pg_strcasecmp(prev_wd, "END") == 0 ||

Regards,
Andreas Karlsson

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-12-18 01:50:54 Re: unlogged tables vs. GIST
Previous Message David E. Wheeler 2010-12-18 01:22:16 Re: plperlu problem with utf8