| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: remove redundant code from pl_exec.c |
| Date: | 2010-12-17 15:17:54 |
| Message-ID: | 1292598926-sup-4738@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Pavel Stehule's message of vie dic 17 07:02:00 -0300 2010:
> Hello
>
> This patch remove redundant rows from PL/pgSQL executor (-89 lines).
> Doesn't change a functionality.
Hmm I'm not sure but I think the new code has some of the result values
inverted. Did you test this thoroughly? I think this would be a nice
simplification because the repetitive coding is ugly and confusing, but
I'm nervous about the unstated assumption that all loop structs are
castable to the new struct. Seems like it could be easily broken in the
future.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-17 15:22:41 | Re: Unnecessary limit on max_standby_streaming_delay |
| Previous Message | Tom Lane | 2010-12-17 15:17:02 | Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files) |