| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: fix ancient typo in transformRelOptions() |
| Date: | 2025-08-05 22:10:54 |
| Message-ID: | 1290107.1754431854@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> On 2025-Aug-05, Nathan Bossart wrote:
>> I noticed that this function has a "namspace" parameter. The attached
>> patch adds the missing 'e'.
> I have vague recollections of it being this way because of "namespace"
> being a C++ keyword. (commit is 3a5b77371522, but I don't have energy
> to look for the discussion right now.)
Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
I didn't locate the discussion of "namspace" either, but I did
notice that de160e2c0 used "nameSpace" for the same purpose.
Maybe we should standardize on that? It looks less like a typo
than "namspace", for sure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-08-05 22:14:44 | Re: fix ancient typo in transformRelOptions() |
| Previous Message | Masahiko Sawada | 2025-08-05 22:07:25 | Re: Convert varatt.h macros to static inline functions |