From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: fairywren is generating bogus BASE_BACKUP commands |
Date: | 2022-01-21 22:42:45 |
Message-ID: | 1289349.1642804965@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> c.f. src/bin/pg_verifybackup/t/003_corruption.pl which says:
> my $source_ts_prefix = $source_ts_path;
> $source_ts_prefix =~ s!(^[A-Z]:/[^/]*)/.*!$1!;
> ...
> # See https://www.msys2.org/wiki/Porting/#filesystem-namespaces
> local $ENV{MSYS2_ARG_CONV_EXCL} = $source_ts_prefix;
> Probably in this case just setting it to 'server:' would do the trick.
The point I was trying to make is that if we have to jump through
that sort of hoop in the test scripts, then real users are going
to have to jump through it as well, and they won't like that
(and we will get bug reports about it). It'd be better to design
the option syntax to avoid such requirements.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-01-21 22:53:25 | Re: New developer papercut - Makefile references INSTALL |
Previous Message | John Naylor | 2022-01-21 22:41:58 | Re: do only critical work during single-user vacuum? |