| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup wish list |
| Date: | 2016-09-12 19:31:37 |
| Message-ID: | 12873.1473708697@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 8/19/16 1:04 AM, Masahiko Sawada wrote:
>> I agree with adding this as an option and removing directory by default.
>> And it looks good to me except for missing new line in usage output.
>>
>> printf(_(" -l, --label=LABEL set backup label\n"));
>> + printf(_(" -n, --noclean do not clean up after errors"));
>> printf(_(" -P, --progress show progress information\n"));
> Committed with that fix. Thanks.
Hm, there was just a kerfuffle about spelling things like this
"--no-clean" etc. I wasn't on board with removing existing spellings,
but surely all newly added switches should use the "no-" spelling?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2016-09-12 19:39:56 | inappropriate use of NameGetDatum macro |
| Previous Message | Peter Eisentraut | 2016-09-12 19:26:57 | Re: pg_basebackup wish list |