Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().
Date: 2010-08-25 15:46:16
Message-ID: 1282751176.3865.1500.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, 2010-08-16 at 02:02 +0000, Robert Haas wrote:
> Log Message:
> -----------
> Make LockDatabaseObject() AcceptInvalidationMessages().
>
> This is appropriate for the same reasons we already do it in
> LockSharedObject(): things might have changed while we were waiting
> for the lock. There doesn't seem to be a live bug here at the moment,
> but that's mostly because it isn't currently used for very much.

I have a horrible nagging feeling this breaks something. I remember
noticing that about a year ago and it seemed to make sense then. Sorry,
can't recall anything else at present.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-08-25 16:39:25 Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().
Previous Message Simon Riggs 2010-08-25 11:50:41 Re: pgsql: Correct sundry errors in Hot Standby-related comments.