Re: Convert varatt.h macros to static inline functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Convert varatt.h macros to static inline functions
Date: 2025-08-05 20:59:14
Message-ID: 1282336.1754427554@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
> On Tue, Aug 5, 2025 at 11:34 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Interesting. I did not see such warnings with gcc 14.3.1, 15.1.1,
>> nor older gcc versions. Must be something peculiar to 14.2.

> Hmm, I got the same warning with 14.3.1 (exact version shown below) so
> probably something is strange on my end:

> % gcc --version
> gcc (GCC) 14.3.1 20250805

That's even more interesting. The specific late-model gcc versions
I checked were from Fedora 41:

$ gcc --version
gcc (GCC) 14.3.1 20250523 (Red Hat 14.3.1-1)

and Fedora 42:

gcc (GCC) 15.1.1 20250521 (Red Hat 15.1.1-2)

Maybe there's some strange cross-distro difference here, but
what I'm wondering is if there's a difference in CFLAGS.
My build used

CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-05 21:03:33 fix ancient typo in transformRelOptions()
Previous Message Tomas Vondra 2025-08-05 20:56:25 Re: index prefetching