Re: lock_timeout GUC patch - Review

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Marc Cousin <cousinmarc(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: lock_timeout GUC patch - Review
Date: 2010-07-30 23:06:30
Message-ID: 1280531119-sup-8728@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Boszormenyi Zoltan's message of jue jul 29 07:55:38 -0400 2010:
> Hi,
>
> Marc Cousin írta:
> > Hi, I've been reviewing this patch for the last few days. Here it is :
> >
> ...
> > * Are there dangers?
> > As it is a guc, it could be set globally, is that a danger ?
> >
>
> I haven't added any new code covering supplemental (e.g. autovacuum)
> processes,
> the interactions are yet to be discovered. Setting it globally is not
> recommended.

FWIW there is some code in autovacuum and other auxiliary processes that
forcibly sets statement_timeout to 0. I think this patch should do
likewise.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-07-31 01:55:45 Re: reducing NUMERIC size for 9.1
Previous Message Robert Haas 2010-07-30 21:58:03 reducing NUMERIC size for 9.1, take two