Re: File system operations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: File system operations.
Date: 2016-09-15 16:09:16
Message-ID: 1278.1473955756@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Sep 15, 2016 at 11:01 AM, Anastasia Lubennikova
> <a(dot)lubennikova(at)postgrespro(dot)ru> wrote:
>> What do you think about moving stuff from pg_upgrade/file.c to storage/file/
>> to allow reuse of this code? I think it'll be really helpful for developers
>> of contrib modules
>> like backup managers.

> Well, storage/file is backend and pg_upgrade is frontend. If you want
> to reuse the same code for both it's got to go someplace else.

Also, to the extent that it's important to use those wrappers rather
than libc directly, it's because the wrappers are tied into backend
resource management and error handling conventions. I don't see how
you convert that into code that also works in a frontend program,
or what the point would be exactly.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2016-09-15 16:16:52 Re: Vacuum: allow usage of more than 1GB of work mem
Previous Message Tom Lane 2016-09-15 16:06:43 Re: Surprising behaviour of \set AUTOCOMMIT ON