Re: Revised patches to add table function support to PL/Tcl (TODO item)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Karl Lehenbauer <karllehenbauer(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Revised patches to add table function support to PL/Tcl (TODO item)
Date: 2010-12-29 00:29:42
Message-ID: 12765.1293582582@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Karl Lehenbauer <karllehenbauer(at)gmail(dot)com> writes:
> The first patch, pltcl-karl-try2-1-of-3-pgindent.patch, does nothing but conform HEAD's pltcl.c with pgindent. Applying this patch should have exactly the same effect as running
> src/tools/pgindent/pgindent src/tools/pgindent/typedefs.list src/pl/tcl/pltcl.c

This patch appears to be changing a whole lot of stuff that in fact
pg_indent has never changed, so there's something wrong with the way you
are doing it. It looks like a bad typedef list from here.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2010-12-29 01:18:46 Re: pg_dump --split patch
Previous Message Tom Lane 2010-12-29 00:24:57 Re: pg_dump --split patch