Re: max_standby_delay considered harmful

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: max_standby_delay considered harmful
Date: 2010-05-12 06:50:57
Message-ID: 1273647057.308.306.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2010-05-11 at 14:01 +0900, Fujii Masao wrote:
> On Mon, May 10, 2010 at 3:27 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > I already explained that killing the startup process first is a bad idea
> > for many reasons when shutdown was discussed. Can't remember who added
> > the new standby shutdown code recently, but it sounds like their design
> > was pretty poor if it didn't include shutting down properly with HS. I
> > hope they fix the bug they have introduced. HS was never designed to
> > work that way, so there is no flaw there; it certainly worked when
> > committed.
>
> New smart shutdown during recovery doesn't kill the startup process until
> all of the read only backends have gone away. So it works fine with HS.

Yes, I thought some more about what Robert said. HS works identically to
normal running in this regard, so there's no hint of a bug or design
flaw on that for either of us to worry about.

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-05-12 10:01:32 HS starting snapshot corrections
Previous Message Bruce Momjian 2010-05-12 02:22:50 Re: pg_migrator to /contrib in a later 9.0 beta