| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| Date: | 2010-04-28 08:00:04 |
| Message-ID: | 1272441604.4161.9702.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, 2010-04-28 at 10:43 +0300, Heikki Linnakangas wrote:
> * renamed wal_mode to wal_level
I'm wondering whether this should be a list rather than an enum? If we
add something in the future that adds more info to WAL but doesn't fit
the one-dimensional model this implements then we could be in trouble.
Should this be
e.g. wal_xxxx = feature2, feature3
e.g. wal_xxxx = feature3
e.g. wal_xxxx = feature1
recognising that some features require other features, so as an example
feature2 requires and implies feature1.
The word "level" implies a one-dimensionality that "mode" did not and I
feel a little uncertain about that term.
Other words: attributes, features, contents, info, options.
Hmm, wal_options sounds OK.
Anyway, just throwing out some ideas to make sure we're doing the right
thing with this.
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-04-28 08:27:20 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| Previous Message | Heikki Linnakangas | 2010-04-28 07:43:06 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume (ioguix) de Rorthais | 2010-04-28 08:11:20 | Re: providing tokenized version of parsed SQL script |
| Previous Message | Heikki Linnakangas | 2010-04-28 07:47:02 | Re: Error handling for ShmemInitStruct and ShmemInitHash |