On Tue, 2010-04-27 at 18:08 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > On Tue, 2010-04-27 at 17:24 -0400, Tom Lane wrote:
> >> I think we should just lose that test, as well as the variable.
> > Yes, though it looks like it is still necessary in creating a valid
> > initial state because otherwise we may have xids in KnownAssigned array
> > that are already complete.
> Huh? How is a filter as coarse as an oldest-running-XID filter going
> to prevent that? And aren't we initializing from trustworthy data in
> ProcArrayApplyRecoveryInfo, anyway?
> I still say it's useless.
Quite possibly. Your looking at other code outside of this patch. I'm
happy that you do so, but is it immediately related? I can have another
look when we finish this.
Simon Riggs www.2ndQuadrant.com
In response to
pgsql-hackers by date
|Next:||From: Kjell Rune Skaaraas||Date: 2010-04-27 22:45:56|
|Subject: Add column if not exists (CINE)|
|Previous:||From: Mike Fowler||Date: 2010-04-27 22:42:06|
|Subject: XML Todo List|