| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Wierd quirk of HS/SR, probably not fixable |
| Date: | 2010-04-27 16:08:07 |
| Message-ID: | 1272384487.4161.7621.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2010-04-27 at 18:13 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > If pg_stop_backup() is run it creates the .backup file in the archive.
> > In the absence of that file, we should be able to work out that
> > pg_stop_backup() was not run.
>
> It's just as likely that the file is there even though the backup didn't
> finish, though.
It's possible, but not likely. It would need to break at a very specific
place for that to be the case. Whereas the test I explained would work
for about 99% of the time between start and stop backup, except for the
caveat I explained also. I'm not sure that pointing out a minor hole
stops it being a worthwhile test? Surely if you care to fix the problem
then a better test can only be a good thing?
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2010-04-27 16:14:30 | Re: Differential backup |
| Previous Message | Tom Lane | 2010-04-27 15:42:58 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |