| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per |
| Date: | 2010-04-05 19:42:21 |
| Message-ID: | 1270496541.24910.4837.camel@ebony |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, 2010-04-05 at 15:02 -0400, Alvaro Herrera wrote:
> Simon Riggs escribió:
> > On Mon, 2010-04-05 at 17:08 +0900, Fujii Masao wrote:
> > > On Sat, Apr 3, 2010 at 6:50 AM, Simon Riggs <sriggs(at)postgresql(dot)org> wrote:
> > > > Log Message:
> > > > -----------
> > > > Check compulsory parameters in recovery.conf in standby_mode, per docs.
> > >
> > > On the recent discussion (*1), some people argued that specifying neither
> > > primary_conninfo nor restore_command in the standby mode is not unreasonable,
> > > and we reached the consensus that the setting should be allowed. So this
> > > commit doesn't reflect the discussion. How about reverting the commit,
> > > and restarting the discussion if you have complaint against the consensus?
> >
> > The attached patch changes the messages and downgrades FATAL to WARNING.
> >
> > Comments?
>
> Please note that errdetail must be a complete sentence.
Better?
--
Simon Riggs www.2ndQuadrant.com
| Attachment | Content-Type | Size |
|---|---|---|
| msg_change.patch | text/x-patch | 980 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-04-05 19:48:41 | Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per |
| Previous Message | Alvaro Herrera | 2010-04-05 19:02:39 | Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-04-05 19:48:41 | Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per |
| Previous Message | Alvaro Herrera | 2010-04-05 19:02:39 | Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per |