Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Date: 2010-04-05 09:32:38
Message-ID: 1270459958.24910.2999.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, 2010-04-05 at 17:08 +0900, Fujii Masao wrote:
> On Sat, Apr 3, 2010 at 6:50 AM, Simon Riggs <sriggs(at)postgresql(dot)org> wrote:
> > Log Message:
> > -----------
> > Check compulsory parameters in recovery.conf in standby_mode, per docs.
>
> On the recent discussion (*1), some people argued that specifying neither
> primary_conninfo nor restore_command in the standby mode is not unreasonable,
> and we reached the consensus that the setting should be allowed. So this
> commit doesn't reflect the discussion. How about reverting the commit,
> and restarting the discussion if you have complaint against the consensus?
>
> (*1) http://archives.postgresql.org/pgsql-hackers/2010-03/msg01306.php

This change was made because on a separate thread Robert Haas complained
about the server hanging when only standby_mode was set. I verified the
hang and "fixed" the issue. I have added a comment to the previous
thread to restart the discussion.

If the capability that the server sit quietly doing nothing for ever was
somehow important then we should document that both in code and in docs.

I am very disconcerted that there are still no docs whatsoever to
describe how the server works in these new modes.

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-04-05 09:35:53 Re: pgsql: Add contraint exclusion section to contraint docs.
Previous Message Fujii Masao 2010-04-05 08:08:59 Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-04-05 09:35:53 Re: pgsql: Add contraint exclusion section to contraint docs.
Previous Message Fujii Masao 2010-04-05 09:03:47 Re: Parameter name standby_mode