Re: pg_dump sort order for functions

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump sort order for functions
Date: 2010-02-15 14:48:11
Message-ID: 1266245291.6163.4.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tis, 2010-01-12 at 16:35 +0200, Peter Eisentraut wrote:
> Um, that tag is the "name", and if you change that, the name in CREATE
> FUNCTION also changes. I was initially thinking in that direction, but
> it seems it won't be feasible without significant refactoring.
>
> In the mean time, hacking it into the sort function itself as a special
> case works out fine, per attached patch. One might frown upon such an
> exception, but then again, function overloading is an exception to the
> one-name-per-object rule all over the place anyway. ;-)

Since we ran out of time/ideas on this, I would propose just committing
the part that breaks ties based on the number of arguments, which
already solves a large part of the problem (at least in a pre-default
values world) and would very likely be a part of any possible future
utterly complete solution.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-02-15 14:51:21 Re: alpha4 timing (was: Speed up CREATE DATABASE)
Previous Message Euler Taveira de Oliveira 2010-02-15 14:45:02 Re: TCP keepalive support for libpq