Re: [COMMITTERS] pgsql: Reduce the chatter to the log when starting a standby server.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Reduce the chatter to the log when starting a standby server.
Date: 2010-02-12 14:42:58
Message-ID: 1265985778.7341.4143.camel@ebony
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, 2010-02-12 at 09:49 +0000, Heikki Linnakangas wrote:
> Log Message:
> -----------
> Reduce the chatter to the log when starting a standby server. Don't
> echo all the recovery.conf options. Don't emit the "initializing
> recovery connections" message, which doesn't mean anything to a user.
> Remove the "starting archive recovery" message and replace the
> "automatic recovery in progress" message with a more informative message
> saying whether the server is doing PITR, normal archive recovery, or
> standby mode.

Not happy with these changes without discussion.

* "entering standby mode" isn't a more informative message. Two people
have already said on-list that "standby mode" name might need to be
changed. More informative, for me, would be something like "entering
streaming replication mode" and having a parameter called replication
would also make that clearer.

* If you change the HS startup messages you need to change the docs also

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-02-12 14:46:25 Re: Parameter name standby_mode
Previous Message Tom Lane 2010-02-12 14:40:48 Re: review: More frame options in window functions

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-02-12 14:53:22 pgsql: Update Hot Standby documentation to reflect the change in the LOG
Previous Message Simon Riggs 2010-02-12 14:34:29 Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL