Re: An example of bugs for Hot Standby

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Hiroyuki Yamada <yamada(at)kokolink(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: An example of bugs for Hot Standby
Date: 2010-01-21 09:11:27
Message-ID: 1264065087.4043.6494.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2010-01-21 at 18:01 +0900, Hiroyuki Yamada wrote:

> I think the patch has two problems.
>
> * disable_standby_sig_alarm() does not clear standby_timeout_active flag
> when it succeeds in disabling the alarm.

Ah, thanks.

> * Assertion check in HoldingBufferPinThatDelaysRecovery() can fail
> with following scenario.

Agreed. Will remove Assert() because of race conditions.

Thanks,

--
Simon Riggs www.2ndQuadrant.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joachim Wieland 2010-01-21 09:14:57 Re: Listen / Notify - what to do when the queue is full
Previous Message Hiroyuki Yamada 2010-01-21 09:01:20 Re: An example of bugs for Hot Standby